-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --version
CLI flag
#556
Conversation
Ah you already discuss the prefixing in the PR description... But many tools already prefix it, like |
I'm also perfectly fine with somebody else going through the alternative solutions linked in the PR description, my requirements right now are:
To be more specific, I could see somebody implementing the prefixing, but than someone else needs to go ahead and handle this in all of the tooling. |
I agree it is simpler to process, but you probably need to parse the version anyways, no? If not, then lexicographic ordering would also work for a stable prefix, still. I am just saying: I know how to strip a prefix in javascript ( |
It complicates the tooling [IMO a bit unnecessarily], but I really need this PR to go through to unblock the other ones, so I'll concede the point and just do Now the question is: are we happy with this format? It will be really difficult to change it afterwards, so please, if there's anybody who wants the output to look differently, now's your chance, please speak up! |
You can also just go with the version number and I'll ask the Scallop developer to help us. |
I don't have a strong preference so choose what you prefer and I'll handle the rest :) |
I went ahead and customised all of the tooling so that it can handle a prefix, now I just want some confidence vote on the specific prefix to be used so that I don't have to support multiple different ones in the future. ... so, does anybody want a different format? |
Resolves #540
Scallop already supports printing out a version just by calling
version(<your version identifier>)
(see docs here), let's just use it :)Usage
(I changed my version in
build.sbt
in order to make this very visible)Help page
The version also gets printed out on
--help
:Note that we could add a larger "Usage: effekt ..."-style banner, see here.