Skip to content

Commit

Permalink
fix: no need to target_include_directories (#11)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
This removes the `target_include_directories` introduced in #6 again,
since the `target_link_libraries` introduced in #5 set the include
directories the right way.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [X] Other: technical debt reduction

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
  • Loading branch information
wdconinc authored Sep 20, 2022
1 parent 53b04e9 commit aedadc9
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ PODIO_GENERATE_DATAMODEL(edm4eic edm4eic.yaml headers sources
PODIO_ADD_DATAMODEL_CORE_LIB(edm4eic "${headers}" "${sources}"
OUTPUT_FOLDER ${CMAKE_CURRENT_BINARY_DIR}
)
# The target for the data model library is defined in podio/cmake/podioMacros.cmake
# Any changes to that target name upstream may require changes to the target used here
target_include_directories(edm4eic PUBLIC ${EDM4HEP_INCLUDE_DIR})
# It's our responsibility to link to upstream datamodel
target_link_libraries(edm4eic PRIVATE EDM4HEP::edm4hep)

Expand Down

0 comments on commit aedadc9

Please sign in to comment.