lowered the amount of distance neighbor hits in topoclustering in the ZDC

[sebouh137]

Briefly, what does this PR introduce?

Redefines neighboring subcell hits in the ZDC (in the context of topo clustering) to be the nearest neighbors only for hits in the same layer, and the same position for hits in adjacent layers. This change reduces the cases where showers from different particles are merged into a single cluster

What kind of change does this PR introduce?

• Bug fix (issue #__)
• New feature (issue #__)
• Documentation update
• Other: parameter tweak

Please check if this PR fulfills the following:

• Tests for the changes have been added
• Documentation has been added / updated
• Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no.

Does this PR change default behavior?

yes. Changes the default behavior of the topo clustering in the ZDC

[github-actions]

Capybara summary for PR 1532

• rec_dis_10x100_minQ2=0_craterlake
• rec_dis_10x100_minQ2=1000_craterlake_tracking_only
• rec_dis_18x275_minQ2=0_craterlake
• rec_dis_18x275_minQ2=1000_craterlake
• rec_dis_5x41_minQ2=0_craterlake
• rec_e_1GeV_20GeV_craterlake
• rec_pi_1GeV_20GeV_craterlake
  ^{_{Last updated 2024-08-05T12:47-04:00 b4f8dfa}}

[ruse-traveler]

Looks reasonable to me! I have an extremely minor nitpick, but otherwise seems good.

Just so I could educate myself: are there some studies that shows the impact of this tweak? I was having a hard time getting a feel for how this changes things just from the capybara...

[veprbl]

@sebouh137 Is this ready? Can you address the review question?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sebouh137]

@sebouh137 Is this ready? Can you address the review question?

Hi @veprbl I determined that this change was necessary in the context of the Lambda benchmark in the ZDC,
eic/physics_benchmarks#19 , since I was seeing a lot of events where clusters were being merged together when they shouldn't be merging (causing a lot of events to have only one cluster, when they should have two or ideally three if the two photons's and the neutron's showers can be distinguished from one another). I can make some plots with and without this change to the EICrecon

[veprbl]

Feel free to post figures as they become available.