Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reco.cc: add InclusiveKinematicseSigma backwards compatibility for now #1577

Merged
merged 10 commits into from
Aug 24, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Aug 16, 2024

Provide a graceful deprecation for #1572

src/global/reco/reco.cc Outdated Show resolved Hide resolved
@wdconinc
Copy link
Contributor

What is this? Windows?

wdconinc
wdconinc previously approved these changes Aug 17, 2024
@wdconinc wdconinc enabled auto-merge August 17, 2024 02:28
@veprbl
Copy link
Member Author

veprbl commented Aug 17, 2024

What is this? Windows?

Dot files are not converting, there might be a regex issue.

@wdconinc
Copy link
Contributor

Offending dot file has a subgraph cluster_18 that's just empty... But I think what really fixes this for me is upgrading graphviz. I'll see to push that out to nightly.

@wdconinc
Copy link
Contributor

Offending dot file has a subgraph cluster_18 that's just empty....

Must have always been empty due to LFHCAL duplicate naming:

-PJANADOT:GROUP:HcalEndcapP=edm4hep::SimCalorimeterHit:HcalEndcapPHits,edm4hep::RawCalorimeterHit:HcalEndcapPRawHits,edm4eic::CalorimeterHit:HcalEndcapPRecHits,edm4eic::ProtoCluster:HcalEndcapPIslandProtoClusters,edm4eic::Cluster:HcalEndcapPClusters,edm4eic::MCRecoClusterParticleAssociation:HcalEndcapPClusterAssociations,color_red

@veprbl
Copy link
Member Author

veprbl commented Aug 19, 2024

No cigar

@wdconinc
Copy link
Contributor

No cigar

Yeah, I'd restarted some jobs which should have picked up a new graphviz, and no luck.

Maybe we need to make the graphviz job to allow failure. And figure out the issue on the side.

@veprbl veprbl force-pushed the pr/InclusiveKinematicseSigma branch from 7a56abe to e3007ea Compare August 22, 2024 23:36
github-merge-queue bot pushed a commit that referenced this pull request Aug 23, 2024
The issues with rendering the factory graph are cropping in. Example
PRs: #1577 #1576
Copy link

@wdconinc wdconinc added this pull request to the merge queue Aug 24, 2024
Merged via the queue into main with commit 2a1e553 Aug 24, 2024
87 checks passed
@wdconinc wdconinc deleted the pr/InclusiveKinematicseSigma branch August 24, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants