Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deterministic cluster time #1584

Merged
merged 2 commits into from
Aug 25, 2024
Merged

fix: deterministic cluster time #1584

merged 2 commits into from
Aug 25, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR makes the cluster time deterministic, and not based on the whim of which hit happens to be first. It defines the cluster time as the energy-weighted average of all hit times.

This is not the only deterministic choice here (earliest hit is another).

What kind of change does this PR introduce?

  • Bug fix (issue: cluster time depends on hit ordering)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added the topic: calorimetry relates to calorimetry label Aug 19, 2024
Copy link
Contributor

@ruse-traveler ruse-traveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Very nice!

This looks good to me, though I'm curious about the pros-and-cons of using the time-weighted time vs. earliest.

src/algorithms/calorimetry/CalorimeterClusterRecoCoG.cc Outdated Show resolved Hide resolved
Copy link

@wdconinc wdconinc requested a review from veprbl August 20, 2024 20:48
Copy link
Contributor

@ruse-traveler ruse-traveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wdconinc wdconinc added this pull request to the merge queue Aug 25, 2024
Merged via the queue into main with commit a487330 Aug 25, 2024
86 of 87 checks passed
@wdconinc wdconinc deleted the cluster-time branch August 25, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: calorimetry relates to calorimetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants