Update to seed finder distance parameter #1586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This updates the parameter which defines the max distance in r between middle and top SP in a given seed. This removes some minor inefficiencies for |z| > ~50mm at certain eta values, as discussed here. Since the beam diamond extends out to 80-100mm, this allows efficient seed finding over the whole range.
Results for single negative muons generated at with p = [0.5,20]GeV/c and (vx,vy,vz) = (0,0,50mm)
Before:
After:
The results look similar for particles generated at vz = 75mm.
For particles generated at (vx,vy,vz) = (0,0,0), for example, there is no observed difference in the solved tracks (i.e. tracks after the ambiguity solver). The number of found seeds and unsolved tracks increases as expected.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Yes, small improvement to tracking efficiency