Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to seed finder distance parameter #1586

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Update to seed finder distance parameter #1586

merged 6 commits into from
Aug 22, 2024

Conversation

bschmookler
Copy link
Contributor

Briefly, what does this PR introduce?

This updates the parameter which defines the max distance in r between middle and top SP in a given seed. This removes some minor inefficiencies for |z| > ~50mm at certain eta values, as discussed here. Since the beam diamond extends out to 80-100mm, this allows efficient seed finding over the whole range.

Results for single negative muons generated at with p = [0.5,20]GeV/c and (vx,vy,vz) = (0,0,50mm)

Before:
picture1

After:
picture2

The results look similar for particles generated at vz = 75mm.

For particles generated at (vx,vy,vz) = (0,0,0), for example, there is no observed difference in the solved tracks (i.e. tracks after the ambiguity solver). The number of found seeds and unsolved tracks increases as expected.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: Update to seed finder configuration

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators @Jeet-bhai

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Yes, small improvement to tracking efficiency

@bschmookler bschmookler requested a review from ShujieL August 20, 2024 16:50
@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Aug 20, 2024
@ShujieL ShujieL enabled auto-merge August 22, 2024 18:49
Copy link

@ShujieL ShujieL added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 81ff2fa Aug 22, 2024
86 of 87 checks passed
@ShujieL ShujieL deleted the seed_finder_volume branch August 22, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants