feat: produce *RawHitAssociations in CalorimeterHitDigi #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: calorimetry
wdconinc
commented
Aug 24, 2024
Capybara summary for PR 1601 |
wdconinc
requested review from
a team and
veprbl
and removed request for
a team
wdconinc
force-pushed
the
calorimeter-hit-digi-associations
branch
from
3fb5b8b to
8c0cd6c
Compare
|
Diffs look sensible, asides from digitization randomization. EcalBarrelImagingRawHitAssociations (non-merged hits, each raw hit has single sim hit with weight 1) EcalBarrelScFiRawHitAssociations (merged hits, each raw hit composed of many sim hits with weight << 1) |
veprbl
reviewed
Aug 27, 2024
veprbl
reviewed
Aug 27, 2024
wdconinc
force-pushed
the
calorimeter-hit-digi-associations
branch
from
c0efaed to
c19fc5d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR modifies CalorimeterHitDigi to produce raw hit associations (i.e. assocations from raw hits back to sim hits, and then from there MCParticles). The weighting is done based on total energy, and only non-trivial when merging hits.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.