Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated MIP value in insert; also adjusted parameters of the topo clustering #1611

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

sebouh137
Copy link
Contributor

@sebouh137 sebouh137 commented Sep 10, 2024

Briefly, what does this PR introduce?

Updates the MIP value used in the HEXPLIT algorithm in the calorimeter insert. Also lowers the threshold for the center hit in a cluster. Doing this fixes issues in the benchmark for neutron reconstruction ( see eic/physics_benchmarks#32 ).

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: Parameter update

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

yes. Changes the parameters of the topo clustering.

Copy link

@sebouh137 sebouh137 added this pull request to the merge queue Sep 10, 2024
@veprbl veprbl requested a review from rymilton September 10, 2024 16:50
@veprbl veprbl changed the title updated MIP value in insert; also adjusted parameters of the topo clu… updated MIP value in insert; also adjusted parameters of the topo clustering Sep 10, 2024
Merged via the queue into main with commit 8f85181 Sep 10, 2024
86 of 87 checks passed
@sebouh137 sebouh137 deleted the insert_mip branch September 10, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants