Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated parameters for clustering in the forward Ecal #1613

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

sebouh137
Copy link
Contributor

@sebouh137 sebouh137 commented Sep 11, 2024

Briefly, what does this PR introduce?

updates clustering parameters in the forward Ecal so that cartesian coordinates are used instead of eta and phi. Also reduces the minimum seed hit energy for clusters

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: parameter change

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

yes

Use the same metric for the proto cluster creating in the EcalEndcapP as is used in the EcalEndcapPInsert
@sebouh137 sebouh137 marked this pull request as ready for review September 19, 2024 19:21
@sebouh137 sebouh137 enabled auto-merge September 19, 2024 19:21
@eic eic deleted a comment from sonarqubecloud bot Sep 19, 2024
@sebouh137 sebouh137 added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit ae5ce86 Sep 19, 2024
85 of 86 checks passed
@sebouh137 sebouh137 deleted the forward_ecal_clustering branch September 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants