-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct xml file being called for different beam settings in CI #1616
Conversation
Is this the script which is run for all of the hepmc3 campaigns? |
I believe so, yes. cc @rahmans1 |
Quality Gate passedIssues Measures |
Capybara summary for PR 1616
|
Will the missing capybara reports return with new names in the next PR? |
I assumed that was because the files with those configurations were never produced on main. |
(Long way to say "Yes") |
Briefly, what does this PR introduce?
Fixes xml being used so that it matches the MC sample being run.
It was noted in the Exclusive Diffractive and Tagging meeting that some of the campaigns appear to be being run with the wrong beamline settings. This only address the problem where I can see it in the CI.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Means the beam is being steered correctly for the MC samples being run in the CI