Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct xml file being called for different beam settings in CI #1616

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

simonge
Copy link
Contributor

@simonge simonge commented Sep 16, 2024

Briefly, what does this PR introduce?

Fixes xml being used so that it matches the MC sample being run.

It was noted in the Exclusive Diffractive and Tagging meeting that some of the campaigns appear to be being run with the wrong beamline settings. This only address the problem where I can see it in the CI.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Means the beam is being steered correctly for the MC samples being run in the CI

@simonge
Copy link
Contributor Author

simonge commented Sep 16, 2024

Is this the script which is run for all of the hepmc3 campaigns?
https://github.com/eic/simulation_campaign_hepmc3/blob/main/scripts/run.sh

@veprbl
Copy link
Member

veprbl commented Sep 16, 2024

Is this the script which is run for all of the hepmc3 campaigns? https://github.com/eic/simulation_campaign_hepmc3/blob/main/scripts/run.sh

I believe so, yes. cc @rahmans1

Copy link

Copy link

@veprbl veprbl enabled auto-merge September 16, 2024 23:44
@veprbl veprbl added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 994963a Sep 17, 2024
87 checks passed
@veprbl veprbl deleted the Update-xml-to-match-beam-settings branch September 17, 2024 06:48
@simonge
Copy link
Contributor Author

simonge commented Sep 17, 2024

Will the missing capybara reports return with new names in the next PR?

@veprbl
Copy link
Member

veprbl commented Sep 17, 2024

I assumed that was because the files with those configurations were never produced on main.

@veprbl
Copy link
Member

veprbl commented Sep 17, 2024

(Long way to say "Yes")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants