Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SiPM-on-Tile ZDC digitization parameters #1621

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

bschmookler
Copy link
Contributor

@bschmookler bschmookler commented Sep 19, 2024

Briefly, what does this PR introduce?

This PR updates the digitization parameters for the SiPM-on-Tile ZDC. The current default parameters place a zero-suppression threshold at 40 ADC channels. With a 15-bit ADC with dynamic range of 800 MeV, this is a cut at 0.98 MeV (~ 2 MIPs). We see that this has an impact on the energy reconstruction for single-particle simulations.

This PR changes following values:

ADC Capacity = 16-bit (65536 channels)
DynamicRange = 1000 MeV (0.015 MeV per ADC channel)
pedSigmaADC = 2
thresholdFactor = 3.0

These parameters are realistic. The HGROC ASIC can have a capacity of 16-bits; a high-energy photon shower can leave up to 800-1000 MeV in a single channel; and a zero-suppression cut of 6 ADC channels (0.2 MIPs) will allow studies of threshold cuts in the 0.2-0.5 MIP range.

The above changes have been discussed with the SiPM-on-Tile DSC lead, Miguel Arratia.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: Digitization parameters update

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators Discussed with @sebouh137 and M. Arratia

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

Yes, for SiPM-on-Tile ZDC

Closes: #1541

@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: far-forward Far forward reconstruction labels Sep 19, 2024
@wdconinc
Copy link
Contributor

@bschmookler Have these updated digitization parameters been conveyed to Jeff and the DAQ group for inclusion in the reference spreadsheet used for rate estimates? That has been the procedure for the other detector digitization parameters, but a lot of this was done before this ZDC was the baseline option.

Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in terms of diffs.

@bschmookler
Copy link
Contributor Author

@bschmookler Have these updated digitization parameters been conveyed to Jeff and the DAQ group for inclusion in the reference spreadsheet used for rate estimates? That has been the procedure for the other detector digitization parameters, but a lot of this was done before this ZDC was the baseline option.

No, these values have not been sent to the DAQ group. I will do that.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschmookler bschmookler added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 8c5f245 Sep 19, 2024
85 of 86 checks passed
@bschmookler bschmookler deleted the SiPM-on-Tile-ZDC-digitization-parameters branch September 19, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: calorimetry relates to calorimetry topic: far-forward Far forward reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants