fix(ci): suppress memory leaks in libJANA.so #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
approved these changes
Oct 10, 2024
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
### Briefly, what does this PR introduce? Since a week or so, CI jobs on `main` have been failing, https://github.com/eic/EICrecon/actions/workflows/linux-eic-shell.yml?query=branch%3Amain. First one was https://github.com/eic/EICrecon/actions/runs/11171861991. This appears to be due to LSan in libJANA.so, e.g. https://github.com/eic/EICrecon/actions/runs/11171861991/job/31058015623#step:9:3979: ``` ================================================================= ==609==ERROR: LeakSanitizer: detected memory leaks Direct leak of 272 byte(s) in 2 object(s) allocated from: #0 0x55e2fb0ba20d in operator new(unsigned long) (/home/runner/work/EICrecon/EICrecon/install/bin/eicrecon+0x10e20d) (BuildId: a5040da1707e76901d07b3ade4bdca35b7daccf2) #1 0x7f2d2a6a06d1 in JStreamLog::JStreamLog(std::ostream const&, char const*) (/opt/local/lib/libJANA.so+0x15d6d1) (BuildId: 7ee8b20a986d2d231d4fb255c9a0cd83b13e422c) Indirect leak of 21 byte(s) in 2 object(s) allocated from: #0 0x55e2fb0ba31d in operator new[](unsigned long) (/home/runner/work/EICrecon/EICrecon/install/bin/eicrecon+0x10e31d) (BuildId: a5040da1707e76901d07b3ade4bdca35b7daccf2) #1 0x7f2d2a6a13dd in JStreamLogBuffer::JStreamLogBuffer(std::basic_streambuf<char, std::char_traits<char>>*, char const*) (/opt/local/lib/libJANA.so+0x15e3dd) (BuildId: 7ee8b20a986d2d231d4fb255c9a0cd83b13e422c) ``` This PR ignores memory leaks in libJANA.so. ### What kind of change does this PR introduce? - [x] Bug fix (issue: https://github.com/eic/EICrecon/actions/runs/11171861991/job/31058015623#step:9:3979) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators: @nathanwbrei (please tag me on a JANA issue and fix so we can remove this again here) ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. (cherry picked from commit c92c8e0)
veprbl
added a commit
that referenced
this pull request
Oct 16, 2024
# Description Backport of #1628 to `v1.18`. --------- Co-authored-by: Wouter Deconinck <[email protected]> Co-authored-by: Dmitry Kalinkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Since a week or so, CI jobs on
mainhave been failing, https://github.com/eic/EICrecon/actions/workflows/linux-eic-shell.yml?query=branch%3Amain. First one was https://github.com/eic/EICrecon/actions/runs/11171861991. This appears to be due to LSan in libJANA.so, e.g. https://github.com/eic/EICrecon/actions/runs/11171861991/job/31058015623#step:9:3979:This PR ignores memory leaks in libJANA.so.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.