Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of BTOF hits #1660

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Fix naming of BTOF hits #1660

merged 3 commits into from
Nov 4, 2024

Conversation

simonge
Copy link
Contributor

@simonge simonge commented Oct 30, 2024

Briefly, what does this PR introduce?

Changes the name of the BTOF hit collections to use Hits instead of Hit. This was inconsistent between the name output from the hit reconstruction and collection collector input.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Hopefully adds the BTOF into the tracking

@simonge
Copy link
Contributor Author

simonge commented Oct 30, 2024

Turns out this does nothing functional because the discrepancy between TOFBarrelRawHits and TOFBarrelRawHit in
https://github.com/eic/EICrecon/blob/main/src/global/tracking/tracking.cc#L53
isn't actually used.

@veprbl veprbl added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit f437575 Nov 4, 2024
84 of 86 checks passed
@veprbl veprbl deleted the BTOF-hit->hits branch November 4, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: barrel topic: PID Relates to PID reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants