Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eicrecon: fail on unrecognized parameters #1670

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 14, 2024

Briefly, what does this PR introduce?

This changes default configuration to use jana:parameter_strictness=2. Should help users agains typos in their parameters. On older versions of JANA2 this should be no-op.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Yes. Users will have to update their invocations if unused parameters are provided, or pass -Pjana:parameter_strictness=0 argument.

Does this PR change default behavior?

Yes

This changes default configuration to use jana:parameter_strictness=2. Should help users agains typos in their parameters. On older versions of JANA2 this should be no-op.
@veprbl

This comment was marked as resolved.

@wdconinc
Copy link
Contributor

On my phone so hard to check on small screen, but what's the reference CI workflow that gets the flags json file to the website, and same for the jana dot?

@veprbl
Copy link
Member Author

veprbl commented Nov 20, 2024

The jsons/dots are uploaded by eicrecon-gun, eicrecon-gun-EcalLumiSpec and eicrecon-dis.

@veprbl veprbl added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit bfeecb7 Nov 20, 2024
84 of 86 checks passed
@veprbl veprbl deleted the pr/enable_parameter_strictness branch November 20, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters with unrecognized names need to be treated as a fatal error
2 participants