Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UndoAfterBurner: skip particles that are not created by generator #1683

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 1, 2024

Briefly, what does this PR introduce?

This provides a file size reduction:

before 3.1M
after 2.7M

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Unlikely.

Does this PR change default behavior?

Yes

@veprbl veprbl requested a review from ajentsch December 1, 2024 23:35
Copy link
Contributor

@ajentsch ajentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice, refined functionality! Thank you!

@veprbl veprbl added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 3dc7ce1 Dec 2, 2024
85 of 86 checks passed
@veprbl veprbl deleted the pr/UndoAfterBurner_no_sim branch December 2, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants