-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
562 detailed trajectory information writer #563
Conversation
…generate detailed trajectory information
Loop over events and write trajectory information
for more information, see https://pre-commit.ci
There seems to be a few things that are not clear in the initial implementation
Proposed solution: Replace "outputTrajectories" in tracking.cc with "CentralCKFTrajectories" or follow the example in other similar factories.
Proposed solution: I am guessing what was intended was to get the eicrecon::TrackingResultTrajectory
and then pass it to an algorithm which can write out the track parameters.
@DraTeots Any comments/suggestions? Is the functionality intended with this factory already available within existing factories? |
@rahmans1 Can we close this? We are now writing trajectories as part of CKFTracking. |
Briefly, what does this PR introduce?
Initial implementation of trajectory writer provided by Shyam
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?