-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use self-hosted runner #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm not sure we need to keep the setup steps.
We can setup the environment and save time there.
How did we test that? I suppose it was configured in the repo settings somehwere (with credentials and all of that)? |
Yeah. It's not hard to set it up. they give you everything basically. But you can't test it in advance. We will see if the next job will be pushed to the runner. We are currently running ci only on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but this PR made me to create this issue #40. 😅
This reverts commit 024c0b4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added needs
options to the format
and clippy_build_and_test
jobs to ensure all jobs execute in sequence. This makes the TOML linter and formatter run first and fail if any issues are found before running clippy_build_and_test
. Before these changes, I noticed that clippy_build_and_test
was running first, which is not optimal.
I also tested running Clippy after cargo build
since I remember that it uses build components and should improve the execution speed. However, tests showed that this is not true as of now; perhaps some changes were made.
This reverts commit ea916e7.
Nice :D My laziness already improving the processes :D |
c306f72
Use our own self hosted runner by choosing it when defining a ci job.