Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use self-hosted runner #37

Merged
merged 9 commits into from
May 24, 2024
Merged

feat: use self-hosted runner #37

merged 9 commits into from
May 24, 2024

Conversation

cernicc
Copy link
Member

@cernicc cernicc commented May 23, 2024

Use our own self hosted runner by choosing it when defining a ci job.

@cernicc cernicc requested a review from a team May 23, 2024 09:53
jmg-duarte
jmg-duarte previously approved these changes May 23, 2024
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not sure we need to keep the setup steps.

We can setup the environment and save time there.

@th7nder
Copy link
Contributor

th7nder commented May 23, 2024

How did we test that? I suppose it was configured in the repo settings somehwere (with credentials and all of that)?

@cernicc
Copy link
Member Author

cernicc commented May 23, 2024

Yeah. It's not hard to set it up. they give you everything basically. But you can't test it in advance. We will see if the next job will be pushed to the runner. We are currently running ci only on main, develop and tagged PRs

More: https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/adding-self-hosted-runners

th7nder
th7nder previously approved these changes May 23, 2024
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@th7nder th7nder added the ready for review Review is needed label May 23, 2024
@cernicc cernicc dismissed stale reviews from th7nder and jmg-duarte via 5fe160a May 23, 2024 14:11
@cernicc cernicc added ready for review Review is needed and removed ready for review Review is needed labels May 23, 2024
serg-temchenko
serg-temchenko previously approved these changes May 23, 2024
Copy link
Contributor

@serg-temchenko serg-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this PR made me to create this issue #40. 😅

@serg-temchenko serg-temchenko added ready for review Review is needed and removed ready for review Review is needed labels May 23, 2024
@serg-temchenko serg-temchenko added ready for review Review is needed and removed ready for review Review is needed labels May 23, 2024
@serg-temchenko serg-temchenko added ready for review Review is needed and removed ready for review Review is needed labels May 24, 2024
serg-temchenko
serg-temchenko previously approved these changes May 24, 2024
Copy link
Contributor

@serg-temchenko serg-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added needs options to the format and clippy_build_and_test jobs to ensure all jobs execute in sequence. This makes the TOML linter and formatter run first and fail if any issues are found before running clippy_build_and_test. Before these changes, I noticed that clippy_build_and_test was running first, which is not optimal.

I also tested running Clippy after cargo build since I remember that it uses build components and should improve the execution speed. However, tests showed that this is not true as of now; perhaps some changes were made.

@serg-temchenko serg-temchenko added the ready for review Review is needed label May 24, 2024
@cernicc
Copy link
Member Author

cernicc commented May 24, 2024

Looks good, but this PR made me to create this issue #40. 😅

Nice :D My laziness already improving the processes :D

th7nder
th7nder previously approved these changes May 24, 2024
aidan46
aidan46 previously approved these changes May 24, 2024
@aidan46 aidan46 mentioned this pull request May 24, 2024
jmg-duarte
jmg-duarte previously approved these changes May 24, 2024
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@cernicc cernicc dismissed stale reviews from jmg-duarte, aidan46, and th7nder via c306f72 May 24, 2024 09:20
@cernicc cernicc added ready for review Review is needed and removed ready for review Review is needed labels May 24, 2024
@cernicc cernicc linked an issue May 24, 2024 that may be closed by this pull request
@cernicc cernicc merged commit 7d8595f into develop May 24, 2024
3 checks passed
@cernicc cernicc deleted the feat/34/hosted-runner branch May 24, 2024 12:12
@serg-temchenko
Copy link
Contributor

Just leaving this here.

Moving Clippy to the end of builds increased the runtime by ~15 minutes.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up a self-hosted runner for the CI
5 participants