Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change project structure #603

Merged
merged 12 commits into from
Nov 26, 2024

Conversation

cernicc
Copy link
Member

@cernicc cernicc commented Nov 22, 2024

Description

This pr contains removal of empty folders and crates movements with code changes to support that.

Primitives changes will be done in other pr.

Changes:

  • All empty folders were removed
  • storagext was moved to the root of the project with corresponding lib and cli crates.
  • mater was also moved to the root with corresponding lib and cli crates.

@cernicc cernicc linked an issue Nov 22, 2024 that may be closed by this pull request
4 tasks
@cernicc cernicc self-assigned this Nov 25, 2024
@cernicc cernicc marked this pull request as ready for review November 25, 2024 08:40
Justfile Show resolved Hide resolved
th7nder
th7nder previously approved these changes Nov 25, 2024
th7nder
th7nder previously approved these changes Nov 25, 2024
jmg-duarte
jmg-duarte previously approved these changes Nov 25, 2024
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cernicc cernicc requested a review from th7nder November 25, 2024 17:55
th7nder
th7nder previously approved these changes Nov 25, 2024
@th7nder th7nder added the ready for review Review is needed label Nov 25, 2024
@cernicc cernicc added ready for review Review is needed and removed ready for review Review is needed labels Nov 25, 2024
@th7nder th7nder merged commit d1773ef into develop Nov 26, 2024
5 checks passed
@th7nder th7nder deleted the chore/578/general-review-project-structure branch November 26, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

general: review project structure
4 participants