-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: libp2p resolver rfc #629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan46
changed the title
rfc: Add RFC for libp2p resolver
docs: Add RFC for libp2p resolver
Dec 9, 2024
jmg-duarte
reviewed
Dec 9, 2024
th7nder
requested changes
Dec 9, 2024
jmg-duarte
changed the title
docs: Add RFC for libp2p resolver
docs: libp2p resolver rfc
Dec 10, 2024
Should this RFC discuss Kademlia too? |
We talked about moving forward with the rendezvous protocol. If we notice that the rendezvous protocol does not scale well we can move to Kademlia after creating an RFC for the upgrade. |
jmg-duarte
previously approved these changes
Dec 16, 2024
jmg-duarte
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Dec 16, 2024
jmg-duarte
reviewed
Dec 16, 2024
3 tasks
jmg-duarte
approved these changes
Dec 17, 2024
th7nder
approved these changes
Dec 17, 2024
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an RFC for the libp2p Peer ID to multiaddr resolver. This application will be used by clients to find the multiaddr associated with a Peer ID of a deal to fetch the file from the storage provider (using the polka-fetch component) I followed the guidelines described in rfc7322.
A follow-up PR will be created for the scraper that collects on-chain information about deals (both historical and current).