feat: Add peer-resolver lib #640
Conversation
aidan46
force-pushed
the
feat/639-resolver-lib-rendezvous
branch
from
6ac62f9 to
e423d2b
Compare
aidan46
force-pushed
the
feat/639-resolver-lib-rendezvous
branch
from
0922b1b to
fd7f21f
Compare
aidan46
added
ready for review
aidan46
added
ready for review
aidan46
added
ready for review
aidan46
added
ready for review
| } | ||
|
|
||
| /// This functions requests the rendezvous_point for new or updated peers since the last cookie. | ||
| pub fn discover(&mut self, rendezvous_point: PeerId) { |
There was a problem hiding this comment.
I'm not sure this function name is good, it isn't really descriptive of what it does.
I know it wraps discover but I'm not convinced by libp2p's naming.
| swarm | ||
| .register(rendezvous_point, rendezvous_point_address, Some(MAX_TTL)) | ||
| .await?; |
There was a problem hiding this comment.
Does this simply "stay on"? In other words, when does this function call exit?
There was a problem hiding this comment.
This function call exits as soon as the peer is registered. The peer knows this when it receives the Registered event from the rendezvous point.
A cookie is passed into the discover function to only receive peers that have changed or joined since the last discover message was served. |
| @@ -0,0 +1,75 @@ | |||
| # Peer Resolver | |||
|
|
|||
| This library is intended for peer discovery in a libp2p network. | |||
There was a problem hiding this comment.
Could you remind me what is the expected usage of this library in our storage solution?
It's kinda hard to imagine for me whether those abstractions are correct, if we write the library first and the usage second.
This looks like a nice example, but not sure whether it will fit/how it will fit in our whole system.
Description
Add the peer-resolver library with bootstrap and client nodes using the rendezvous and identify protocols for peer discovery. Examples for bootstrap, identification and discovery have been added.