Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use subxt wait-for-success #649

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Dec 19, 2024

Description

If you submit a transaction on a block that's a part of the reorg, it's gonna disappear.
Previously we had our own mechanism to detect that traced_submission_with_finalization.
With those changes we're using polkadot mechanisms (fork-aware pool) and don't have to manually detect forks.

This is dependent on #648 and works thanks to paritytech/polkadot-sdk#4639).

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • Have you tested this solution?

@th7nder th7nder added bug Something isn't working enhancement New feature or request labels Dec 19, 2024
@th7nder th7nder added this to the Phase 3 milestone Dec 19, 2024
@th7nder th7nder self-assigned this Dec 19, 2024
Base automatically changed from fix/647/upgrade-polkadot to develop December 19, 2024 15:22
@th7nder th7nder force-pushed the fix/647/ghost-transactions branch from e449915 to 7e1dc61 Compare December 19, 2024 15:25
@th7nder th7nder added the ready for review Review is needed label Dec 19, 2024
@th7nder th7nder mentioned this pull request Dec 19, 2024
29 tasks
@jmg-duarte jmg-duarte enabled auto-merge (squash) December 19, 2024 15:52
@jmg-duarte jmg-duarte merged commit a611d50 into develop Dec 19, 2024
5 checks passed
@jmg-duarte jmg-duarte deleted the fix/647/ghost-transactions branch December 19, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants