Allow configuring logos for multiple languages #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
added
changelog:breaking
This comment has been minimized.
This comment has been minimized.
owi92
force-pushed
the
logo-language-switch
branch
from
187ca44 to
8f5530d
Compare
This comment has been minimized.
This comment has been minimized.
owi92
force-pushed
the
logo-language-switch
branch
from
8f5530d to
827701c
Compare
owi92
force-pushed
the
logo-language-switch
branch
from
827701c to
4284ab7
Compare
owi92
force-pushed
the
logo-language-switch
branch
from
4284ab7 to
c2a568c
Compare
owi92
force-pushed
the
logo-language-switch
branch
from
c2a568c to
9804557
Compare
LukasKalbertodt
requested changes
Dec 18, 2024
There was a problem hiding this comment.
There are some things I would change about the backend implementation, I believe this can be implemented in less code. And I also would add a different check. I have not fully reviewed the frontend yet, as it might be useful to wait for the backend changes to properly assess how to best implement the frontend.
owi92
force-pushed
the
logo-language-switch
branch
from
9804557 to
600137d
Compare
owi92
force-pushed
the
logo-language-switch
branch
from
600137d to
27de244
Compare
|
I did most of the things you commented on. I still need to do what you suggested in #1292 (comment), and contrary to what I said earlier, I would really appreciate if you could tackle the validation logic as laid out in #1292 (comment). Edit: Another thing I still need to address after the latest changes: The code as is right now doesn't know what to do when a wildcard ( |
LukasKalbertodt
requested changes
Dec 19, 2024
owi92
force-pushed
the
logo-language-switch
branch
from
27de244 to
e60b7bc
Compare
LukasKalbertodt
requested changes
Dec 19, 2024
This will allow admins to configure logos in any number of languages, each with the optional properties of size (wide/narrow) and mode (light/dark). The language prop can also be omitted, in which case the respective logo will be used for all languages.
They now use the new configuration "syntax" for our logos.
This will now change the logo based on current language, if applicable logos exist.
owi92
force-pushed
the
logo-language-switch
branch
from
e60b7bc to
1fb48ca
Compare
This is a bit more explicit and flexible than the previous solution where `en` was always the default. Sadly, this is a breaking change for the configuration. In most cases, migrating is just replacing `en` with `default`.
This makes sure for every case/situation there is exactly one logo defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it possible to configure logos for any number of languages (though for now, Tobira only knows what to do with english, german and non-language-specific logos).
This is a breaking change, as it changes the way logo files are configured. Previous configurations won't work anymore.
Specifics and examples for the new configuration will be available in our docs.
Closes #1271