Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move config sync.{user,password} to opencast.* #1296

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Move config sync.{user,password} to opencast.* #1296

merged 1 commit into from
Dec 10, 2024

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Dec 9, 2024

Does the thing.

Closes #1219

@owi92 owi92 added the changelog:breaking Breaking changes label Dec 9, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot temporarily deployed to test-deployment-pr1296 December 9, 2024 16:49 Destroyed
LukasKalbertodt
LukasKalbertodt requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, all UI tests are failing, you still need to adjust the config in tests/util/isolation.ts

@LukasKalbertodt LukasKalbertodt linked an issue Dec 9, 2024 that may be closed by this pull request
Move config sync.{user,password} to opencast.* #1219
Closed
@owi92 owi92 force-pushed the move-oc-credentials-to-oc-config branch from 26ccca4 to e844b2c Compare December 10, 2024 10:04
@github-actions github-actions bot temporarily deployed to test-deployment-pr1296 December 10, 2024 10:06 Destroyed
@owi92 owi92 force-pushed the move-oc-credentials-to-oc-config branch from e844b2c to 5ef0c78 Compare December 10, 2024 10:27
@github-actions github-actions bot temporarily deployed to test-deployment-pr1296 December 10, 2024 10:31 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit 978739b into elan-ev:next Dec 10, 2024
5 checks passed
@owi92 owi92 deleted the move-oc-credentials-to-oc-config branch December 10, 2024 12:28
@LukasKalbertodt LukasKalbertodt mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt requested changes

Assignees
No one assigned
Labels
changelog:breaking Breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move config sync.{user,password} to opencast.*
2 participants
@owi92 @LukasKalbertodt