Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a backend test #1301

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix a backend test #1301

merged 1 commit into from
Dec 12, 2024

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Dec 12, 2024

Tiny fix for can_deserialize_playlist_response.

@owi92
Fix can_deserialize_playlist_response test
6b57650 
This add `preview_roles` to the test that was previously
missing in the `next` branch and didn't know about the
preview roles in ACL yet.
@owi92 owi92 added the changelog:nope Not worth mentioning in the changelog label Dec 12, 2024
@owi92 owi92 changed the base branch from main to next December 12, 2024 16:53
@github-actions GitHub Actions
Copy link

🚨🚨🚨 This PR changes APIs used by the Opencast Admin UI integration 🚨🚨🚨

Detected the following changes (2) between schemas:

⚠  Default value [] was added to argument newRealms on field Mutation.mountSeries
✔  Field Realm.nameSource description changed from The raw information about the name of the realm, showing where the name
is coming from and if there is no name, why that is. Is `null` for the
root realm, non-null for all other realms. to The raw information about the name of the realm, showing where the name
is coming from and if there is no name, why that is. Can be `null` only for the
root realm, must be non-null for all other realms.

LukasKalbertodt
LukasKalbertodt approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@LukasKalbertodt LukasKalbertodt merged commit f38c6e8 into elan-ev:next Dec 12, 2024
5 checks passed
@owi92 owi92 deleted the fix-backend-test branch December 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes

Assignees
No one assigned
Labels
changelog:nope Not worth mentioning in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owi92 @LukasKalbertodt