release instrumentation-openai 0.4.1 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A release with the LICENSE file included fixes an issue with building the *EDOT* Docker image, because the in-'docker build' run of scripts/gen-notice.sh no longer needs to dig into 'packages/instrumentation-openai/...' to find its license file text.
v1v
approved these changes
Dec 18, 2024
david-luna
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A release with the LICENSE file included fixes an issue with
building the EDOT Docker image, because the in-'docker build'
run of scripts/gen-notice.sh no longer needs to dig into
'packages/instrumentation-openai/...' to find its license file
text.
Here is an example of the EDOT Node.js build failure while building its Docker image:
https://github.com/elastic/elastic-otel-node/actions/runs/12382883805
The issue is that it runs gen-notice.sh in the Docker build context,
but a recent workaround comment fixed
gen-notice.shto getthe instr-openai/LICENSE from the source tree. That fails in the
Docker build context. Either we copy that "packages/instrumentation-openai/LICENSE"
into the Docker build context, or we (a) get a new instr-openai release
with a license file, and (b) update EDOT Node.js to use it.
I choose the latter.