Check values in arrays

[jsoriano]

Add validation for all values in arrays.

This is needed when some validation of the values is desired, apart of type validation. This is the case with IPs (elastic/integrations#3408) or event types (#615 (comment)).

This change was part of #771, but this is being delayed due to elastic/integrations#3016.

[mtojek]

A more generic non-blocking comment - it's really easy to get lost in the logic due to multiple switch-cases and "if" clauses. Maybe you should drop a few comments to show field examples including edge cases.

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-05-30T11:08:33.938+0000

• Duration: 32 min 5 sec

Test stats 🧪

Test	Results
Failed	0
Passed	720
Skipped	0
Total	720

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (30/30)	💚
Files	64.22% (70/109)	👍
Classes	58.278% (88/151)	👍
Methods	47.421% (285/601)	👍 0.088
Lines	32.348% (2616/8087)	👎
Conditionals	100.0% (0/0)	💚

[jsoriano]

A more generic non-blocking comment - it's really easy to get lost in the logic due to multiple switch-cases and "if" clauses. Maybe you should drop a few comments to show field examples including edge cases.

I have added comments, and refactored the code to explicitly return type errors instead of having the if valid condition at the end. I have also moved the code to a function for single values, what reduces the nesting level of the main code.

@mtojek let me know what you think.

[mtojek]

Thank you! That's exactly what I meant.