Skip to content

Commit

Permalink
ti_misp: add request rate limit (#11641)
Browse files Browse the repository at this point in the history
Adding the possibility to set the request rate limit for the TI MISP integration.

The nature of API responses that require nested splits to decode events may lead to high resource utilization in the agent, which cannot be avoided by the filters that MISP currently provides. Setting a request rate limit may help in the processing of the responses to avoid the input being overwhelmed.
  • Loading branch information
chemamartinez authored Nov 7, 2024
1 parent e368bfe commit 6926115
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 1 deletion.
5 changes: 5 additions & 0 deletions packages/ti_misp/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.35.7"
changes:
- description: Set request rate limits.
type: bugfix
link: https://github.com/elastic/integrations/pull/11641
- version: "1.35.6"
changes:
- description: Fix the processing of ISO8601 dates.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ request.ssl: {{ssl}}
{{#if http_client_timeout}}
request.timeout: {{http_client_timeout}}
{{/if}}
{{#if http_request_rate_limit}}
request.rate_limit.limit: "{{http_request_rate_limit}}"
{{/if}}
{{#if proxy_url}}
request.proxy_url: {{proxy_url}}
{{/if}}
Expand Down
8 changes: 8 additions & 0 deletions packages/ti_misp/data_stream/threat/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ streams:
required: false
show_user: false
default: 30s
- name: http_request_rate_limit
type: text
title: HTTP Request Rate limit
description: "The maximum per endpoint request rate, in requests per second (e.g. 0.5 reqs/sec for 30 reqs/min). Controlling the rate limit may help with the processing of large responses from the MISP API."
default: 1
multi: false
required: false
show_user: false
- name: filters
type: yaml
title: MISP API Filters
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ request.ssl: {{ssl}}
{{#if http_client_timeout}}
request.timeout: {{http_client_timeout}}
{{/if}}
{{#if http_request_rate_limit}}
request.rate_limit.limit: "{{http_request_rate_limit}}"
{{/if}}
{{#if proxy_url}}
request.proxy_url: {{proxy_url}}
{{/if}}
Expand Down
8 changes: 8 additions & 0 deletions packages/ti_misp/data_stream/threat_attributes/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ streams:
required: false
show_user: false
default: 30s
- name: http_request_rate_limit
type: text
title: HTTP Request Rate limit
description: "The maximum per endpoint request rate, in requests per second (e.g. 0.5 reqs/sec for 30 reqs/min). Controlling the rate limit may help with the processing of large responses from the MISP API."
default: 1
multi: false
required: false
show_user: false
- name: filters
type: yaml
title: MISP API Filters
Expand Down
2 changes: 1 addition & 1 deletion packages/ti_misp/manifest.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: ti_misp
title: MISP
version: "1.35.6"
version: "1.35.7"
description: Ingest threat intelligence indicators from MISP platform with Elastic Agent.
type: integration
format_version: "3.0.2"
Expand Down

0 comments on commit 6926115

Please sign in to comment.