Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] enable asset inventory package to support agentless #11238

Merged
merged 11 commits into from
Oct 8, 2024
Merged

[Cloud Security] enable asset inventory package to support agentless #11238

merged 11 commits into from
Oct 8, 2024

Conversation

Omolola-Akinleye
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye commented Sep 24, 2024 •
edited
Loading

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR

See comment

Screenshots

image image

@Omolola-Akinleye Omolola-Akinleye requested a review from a team as a code owner September 24, 2024 18:00
@andrewkroh andrewkroh added enhancement New feature or request Integration:cloud_asset_inventory Cloud Asset Inventory Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] labels Sep 24, 2024
@eyalkraft
Copy link
Contributor

Seems like it's missing the required organization, division, team fields that @seanrathier added to the spec.

@Omolola-Akinleye Omolola-Akinleye self-assigned this Sep 27, 2024
seanrathier
seanrathier approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@seanrathier seanrathier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Omolola-Akinleye Omolola-Akinleye enabled auto-merge (squash) October 8, 2024 19:42
@Omolola-Akinleye Omolola-Akinleye merged commit 86a8053 into elastic:main Oct 8, 2024
3 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @Omolola-Akinleye

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elastic-vault-github-plugin-prod
Copy link

Package cloud_asset_inventory - 0.2.2 containing this change is available at https://epr.elastic.co/search?package=cloud_asset_inventory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalkraft eyalkraft eyalkraft left review comments

@seanrathier seanrathier seanrathier approved these changes

Assignees

@Omolola-Akinleye Omolola-Akinleye

Labels
enhancement New feature or request Integration:cloud_asset_inventory Cloud Asset Inventory Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Omolola-Akinleye @eyalkraft @elasticmachine @seanrathier @andrewkroh