Fix changelog in network traffic #11322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
andrewkroh
added
Integration:network_traffic
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
memcached |
1834.86 | 832.64 | -1002.22 (-54.62%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
@andrewkroh @efd6 can I get a review on this? Another change was merged on the incorrect version. In latest elastic-package we are adding a check to prevent this, network traffic is failing because of this in #11400. |
💚 Build Succeeded
History
cc @jsoriano |
|
nfritts
approved these changes
Oct 14, 2024
Tacklebox
approved these changes
Oct 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.31.1 and 1.31.2 were released after 1.32.0, including more changes than 1.32.0. Upgrading to 1.32.0 actually causes regression as there is one change that is not included.
Adjust the changelog to represent the current state of packages, and release a new 1.32.1 version that includes the latest changes.
We detected this issue in elastic/package-spec#808, adding validations to try to prevent this kind of problems.