Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okta: do not remove event.original in main ingest #12127

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 16, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Dec 16, 2024
@efd6 efd6 self-assigned this Dec 16, 2024
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 marked this pull request as ready for review December 16, 2024 23:17
@efd6 efd6 requested a review from a team as a code owner December 16, 2024 23:17
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if you provide an event with message and event.original, the event.original will be used and the message will be discarded.

Before this change it was the same, except the message field wouldn't be removed.

I the change is fine.

I wonder if we should be more consistent about using event.original as the source, and any other conventions necessary to make it easier to reprocess events.

@efd6
Copy link
Contributor Author

efd6 commented Dec 17, 2024

I wonder if we should be more consistent about using event.original as the source, and any other conventions necessary to make it easier to reprocess events.

I would like this. I think it's something that we should discuss for the integrations review document.

@efd6 efd6 merged commit d255da9 into elastic:main Dec 17, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package okta - 3.4.0 containing this change is available at https://epr.elastic.co/package/okta/3.4.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants