-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
okta: do not remove event.original in main ingest #12127
Conversation
🚀 Benchmarks reportTo see the full report comment with |
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
cc @efd6 |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if you provide an event with message
and event.original
, the event.original
will be used and the message
will be discarded.
Before this change it was the same, except the message
field wouldn't be removed.
I the change is fine.
I wonder if we should be more consistent about using event.original
as the source, and any other conventions necessary to make it easier to reprocess events.
I would like this. I think it's something that we should discuss for the integrations review document. |
Package okta - 3.4.0 containing this change is available at https://epr.elastic.co/package/okta/3.4.0/ |
Proposed commit message
See title.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots