-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial release of Falco integration #9619
Initial release of Falco integration #9619
Conversation
💚 CLA has been signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an initial review of the ingest pipeline, mappings, and input.
packages/falco/data_stream/falco_alerts/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/falco/data_stream/falco_alerts/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
…edback: - Updated field definitions and mapping of fields within pipeline - Added agent.yml field definitions - Updated test suites and removed unnecessary test - Adding in deployment updates from k8s to Docker - Integration cleanup and asset management - Updated documentation
… and build process
This comment was marked as outdated.
This comment was marked as outdated.
Tests are still not passing due to undocumented fields coming from Falco.
additional pipeline bugfixes
… testing. Added additional test logs for better coverage.
…p handler for fallback.
…ldspec files. Build process currently erroring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the final review but another iteration of completed items.
packages/falco/data_stream/falco_alerts/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/falco/data_stream/falco_alerts/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
- Added validation.yml for skipping dashboard references preventing build - Added screencap of Falco dashboard - Updated sample logs for testing - Updated pipeline and fieldspec to correctly manage nested vs value fields - Updated documentation to match changes
… field naming conventions.
/test |
/test |
/test |
👋
This would allow us to reuse this integration for the Falco Sidekick output that we are POCing with at the moment. Basically with this change:
Here is an example of the typical Falco Sidekick payload
Here is an example of the Elasticsearch document
|
/test |
Hi @aleksmaus, As far as I know, the integration is already compatible with the Falco Sidekick output. Currently, the TCP input includes a syslog processor that decodes incoming syslog messages as the following:
into a JSON object where syslog metadata is added, and the Falco data is placed into the
Therefore, I think adding that change won't have any effect on the pipeline. We'd appreciate it if you could verify that this integration is reusable for your use case and let us know if you find anything you may need. Thanks! |
In our case the users were interested in using Falco with Sidekick without any Agent/Beats.
|
/test |
Thanks for expanding the use case, I still think that given that input, the You can take a look at the pipeline tests that process events with the same format. Maybe I am missing something, in that case please let me know. |
🚀 Benchmarks reportTo see the full report comment with |
What data would it move if there is no I just did a quick test with the POST payload above and the pipeline without my additions and I'm getting the pipeline error in the document
Could you try that POST command above and let me know if I'm missing something? |
My bad, I thought you wanted to reuse the whole integration instead of just the ingest pipeline. It makes sense to me now. In that case, @cole-labar do you mind adding the changes that @aleksmaus suggests here? |
/test |
💚 Build Succeeded
History
|
Quality Gate passedIssues Measures |
Yeah, this is kind of unusual use case, because most of the time we have the data shipped via beats. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package falco - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=falco |
This is an initial release of a new integration for Falco. It captures events (called Alerts in Falco) that are created by Falco's Rules.
What does this PR do?
This is an initial release of a new integration for Falco. It captures events (called Alerts in Falco) that are created by Falco's Rules. It includes:
Checklist
changelog.yml
file.What's Ready for Review:
How to test this PR locally
Related issues
Automated Test
Screenshot