Define beta features in spec

[mtojek]

This PR defines release: beta flag for folder specs. Requested by @joshdover in comment.

Related: #328

It might be hard to test it without providing a fake spec, so I'd rather test it against #328.

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-05-24T12:40:05.135+0000

• Duration: 2 min 21 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[joshdover]

LGTM, thanks for adding this. It would be nice if we could emit warnings when beta features are used in non-GA packages too so that developers aren't surprised right when they're hoping to make a package GA. Let's consider that nice-to-have though unless it's easy to implement now.

[mtojek]

I added a warning. It should appear in the console similarly to this:

2022/05/23 14:20:16 Warning: package with non-stable semantic version and active beta features (enabled in [../../../../test/packages/missing_required_fields/_dev]) can't be released as stable version.

[jsoriano]

Should we check somewhere that we only use beta or ga here? Or even only beta?

[mtojek]

I added a condition to check for "beta" and "ga" and report an error whenever there is a different level used.

[jsoriano]

Nit. Use a switch for valid values to simplify conditions?

Suggested change

	if s.Release != "" && s.Release != "beta" {
	errs = append(errs, errors.Errorf("unsupport release level, supported values: beta, ga"))
	} else if s.Release == "beta" && pkg.Version.Prerelease() == "" {
	errs = append(errs, errors.Errorf("spec for [%s] defines beta features which can't be enabled for packages with a stable semantic version", pkg.Path(path)))
	} else if s.Release == "beta" && pkg.Version.Prerelease() != "" {
	log.Printf("Warning: package with non-stable semantic version and active beta features (enabled in [%s]) can't be released as stable version.q", pkg.Path(path))
	switch s.Release {
	case "", "ga":
	case "beta":
	if pkg.Version.Prerelease() == "" {
	errs = append(errs, errors.Errorf("spec for [%s] defines beta features which can't be enabled for packages with a stable semantic version", pkg.Path(path)))
	} else {
	log.Printf("Warning: package with non-stable semantic version and active beta features (enabled in [%s]) can't be released as stable version.q", pkg.Path(path))
	}
	default:
	errs = append(errs, errors.Errorf("unsupport release level, supported values: beta, ga"))
	}

[mtojek]

Fixed