Add entity definition support

README.md

@@ -41,6 +41,7 @@ For a quick overview, these are the assets typically found in an Elastic Package
   * Security rules
   * CSP (cloud security posture) rule templates
   * SLOs
+  * Entity definitions
 * Other
   * fields.yml
 

code/go/internal/validator/semantic/validate_kibana_matching_object_ids.go

@@ -29,6 +29,9 @@ func ValidateKibanaObjectIDs(fsys fspath.FS) specerrors.ValidationErrors {
 
 	for _, objectFile := range objectFiles {
 		filePath := objectFile.Path()
+		if strings.Contains(filePath, "kibana/entity_definition/") {
+			continue
+		}
 
 		objectID, err := objectFile.Values("$.id")
 		if err != nil {

code/go/internal/validator/semantic/validate_kibana_no_dangling_object_ids.go

@@ -8,6 +8,7 @@ import (
 	"fmt"
 	"path"
 	"slices"
+	"strings"
 
 	"github.com/elastic/package-spec/v3/code/go/internal/fspath"
 	"github.com/elastic/package-spec/v3/code/go/internal/pkgpath"
@@ -43,6 +44,9 @@ func ValidateKibanaNoDanglingObjectIDs(fsys fspath.FS) specerrors.ValidationErro
 	}
 	for _, objectFile := range objectFiles {
 		filePath := objectFile.Path()
+		if strings.Contains(filePath, "kibana/entity_definition/") {
+			continue
+		}
 
 		currentReference, err := getCurrentObjectReference(objectFile, fsys.Path(filePath))
 		if err != nil {

spec/changelog.yml

@@ -4,9 +4,12 @@
 ##
 - version: 3.4.0-next
   changes:
-    - description: Add support for content packages.
-      type: enhancement
-      link: https://github.com/elastic/package-spec/pull/777
+  - description: Add support for content packages.
+    type: enhancement
+    link: https://github.com/elastic/package-spec/pull/777
+  - description: Add support for `entity definition` assets.
+    type: enhancement
+    link: https://github.com/elastic/package-spec/pull/804
 - version: 3.3.0-next
   changes:
     - description: Add support for `slo` assets.

spec/integration/kibana/spec.yml

@@ -136,7 +136,20 @@ spec:
       pattern: '^{PACKAGE_NAME}-.+\.json$'
       forbiddenPatterns:
         - '^.+-(ecs|ECS)\.json$' # ECS suffix is forbidden 
+  - description: Folder containing Kibana Entity definition assets
+    type: folder
+    name: entity_definition
+    required: false
+    contents:
+    - description: An Entity Definition asset file
+      type: file
+      contentMediaType: "application/json"
+      pattern: '^{PACKAGE_NAME}-.+\.json$'
 versions:
+  - before: 3.4.0
+    patch:
+      - op: remove
+        path: "/contents/14" # remove Entity definition definitions
   - before: 3.3.0
     patch:
       - op: remove

test/packages/good_v3/kibana/entity_definition/good_v3-services-from-logs-abc-1.json

@@ -0,0 +1,22 @@
+{
+  "definition": {
+    "id": "services_from_logs",
+    "name": "Extract services from logs",
+    "managed": true,
+    "type": "service",
+    "indexPatterns": ["logs-*"],
+    "identityFields": ["service.name"],
+    "displayNameTemplate": "{{service.name}}",
+    "metadata": [
+      "data_stream.type"
+    ],
+    "history": {
+      "timestampField": "@timestamp",
+      "interval": "1m",
+      "settings": {
+        "frequency": "2m"
+      }
+    },
+    "version": "1.0.0"
+  }
+}

test/packages/good_v3/manifest.yml

@@ -1,4 +1,4 @@
-format_version: 3.3.0
+format_version: 3.4.0
 name: good_v3
 title: Good package
 description: This package is good for format version 3