Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for links and connectors to be used by Kibana #834
Adding support for links and connectors to be used by Kibana #834
Changes from 6 commits
e3cac0c
7d390b1
5932192
0850f9a
37740ff
38577e5
818684c
3dcf866
f2d8847
b50a489
29bedfb
100c75a
fa3536f
c75f3cc
1d26da6
7956499
260b27c
7bb2a15
d10b4a4
e853b00
ca0e1fa
1aa1b1a
e5ecdc7
6050b09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add this new field also for
input
packages ?Policy templates can be defined also in that package type:
package-spec/spec/input/manifest.spec.yml
Line 38 in 9ad6feb
If so, this definition can be moved to the
definitions
key (as for instance howdeployment_modes
is defined) so it can be reused in input packages:definitions
since these are notgeneric
links.Examples on how to reuse/reference a field from
definitions
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrodm I renamed
links
toconfiguration_links
and moved it under thedefinitions
field. It's now referenced both under inputs and policy templates.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the issue description, these links could have also some templating. It would be good to add some examples and include that information in the description.
Probably the description should describe the expected format of this URLs? In the description is mentioned like kibana URLs as
kbn:...
, are other formats allowed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So based on the latest discussions we probably don't need to add this templating here anymore. However I'm not 100% sure about the possible url formats. I'll ask in the main issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanstory could you weigh in about the possible url formats to be used here?