Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting ConnectDial on context #392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajvpot
Copy link

@ajvpot ajvpot commented Jun 23, 2020

Allows the OnRequest handlers to hijack the ConnectDial function to dynamically set a destination, similar to the functionality available for hijacking the RoundTripper for non-CONNECT requests.

@elazarl
Copy link
Owner

elazarl commented Jun 28, 2020

Looks good.

Will the go 1.14 prevent older go versions from using goproxy?

@xzycn
Copy link

xzycn commented May 4, 2022

@elazarl

Hi,can you continue to merge this? This is a good feature for setting different proxy for CONNET method :)

@xzycn
Copy link

xzycn commented May 7, 2022

@elazarl I have tested it with go 1.17.9(go version go1.17.9 linux/amd64), it works fine.
Please review or think about this PR again? This is a key feature for case when making goproxy as a proxy gateway(forward to different upstream proxy) :)

@elazarl
Copy link
Owner

elazarl commented May 8, 2022

@xzycn thanks. Can you check why the CI failed?

@xzycn
Copy link

xzycn commented May 9, 2022

@elazarl Ther eare three tests failed when build in my fork. But the build status is "success".

@xzycn
Copy link

xzycn commented May 9, 2022

@elazarl These tests have the same result in current master. So I think this PR is OK.

@xzycn
Copy link

xzycn commented May 9, 2022

@elazarl Meanwhile,I build with go 1.17,and get the same result ("success"),afterall, this PR dosen't use any new breaking grammar :)

@ErikPelli
Copy link
Collaborator

Is this feature still required or the configurable function ConnectDialWithReq satisfies the purpose of this one? It can do different stuff based on the passed request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants