HTTP error handling customization #492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for parity with HTTPS and the handleHttps function.
This is for parity with HTTPS and the handleHttps function.
If response is nil call httpError like in https code.
The idea is taken from the Stripe fork [1] but instead of context it's set globally for proxy. It gives much flexibility to error handling. [1] https://github.com/stripe/goproxy/blob/3f1dfba6d1a4747c78fee7069e2f28fd6b703917/ctx.go#L21
mmatczuk
force-pushed
the
http_error_handling
branch
from
b7a3b82 to
5692818
Compare
mmatczuk
added a commit
to saucelabs/forwarder
that referenced
this pull request
Nov 9, 2022
My fork is hosting patches I sent upstream to fix issues. It contains patches from * elazarl/goproxy#488 * elazarl/goproxy#492
mmatczuk
added a commit
to saucelabs/forwarder
that referenced
this pull request
Nov 9, 2022
My fork is hosting patches I sent upstream to fix issues. It contains patches from * elazarl/goproxy#488 * elazarl/goproxy#492
mmatczuk
added a commit
to saucelabs/forwarder
that referenced
this pull request
Nov 10, 2022
My fork is hosting patches I sent upstream to fix issues. It contains patches from * elazarl/goproxy#488 * elazarl/goproxy#492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies HTTP and HTTPS error handling and makes it customizable by adding
Proxy.HTTPErrorHandler.Fixes #51