build: upgrade to TypeScript 5.3 #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
reviewed
May 7, 2024
erickzhao
commented
May 7, 2024
Comment on lines
+8
to
+14
| "ts-node": { | ||
| // these options are overrides used only by ts-node | ||
| // same as the --compilerOptions flag and the TS_NODE_COMPILER_OPTIONS environment variable | ||
| "compilerOptions": { | ||
| "module": "commonjs", | ||
| "moduleResolution": "Node" | ||
| } |
There was a problem hiding this comment.
We use ts-node specifically to run docusaurusConfig.ts from docusaurus.config.js.
dsanders11
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates to TypeScript 5, which is a prerequisite for upgrading to Docusaurus 3.
@tsconfig/docusaurus, which now uses thebundlermodule resolution strategy from TS 5.@typescript-eslintwas upgraded to support TS 5.@typescript-eslintdoes not support TS 5.4, we're a bit behind in TS versions.Future work:
@typescript-eslint