Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop usage of node-fetch #571

Merged
merged 1 commit into from
Jun 6, 2024
Merged

chore: drop usage of node-fetch #571

merged 1 commit into from
Jun 6, 2024

Conversation

dsanders11
Copy link
Member

After #494 we can safely use the native fetch in Node.js.

@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-571 June 5, 2024 23:15 Inactive
@dsanders11 dsanders11 marked this pull request as ready for review June 5, 2024 23:18
@dsanders11 dsanders11 requested a review from a team as a code owner June 5, 2024 23:18
erickzhao
erickzhao approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@erickzhao erickzhao merged commit e5a2f9e into main Jun 6, 2024
4 checks passed
@erickzhao erickzhao deleted the chore/drop-node-fetch branch June 6, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsanders11 @ckerr @erickzhao @MarshallOfSound