-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forceful conversion to numbered lists in messages causes messages to change in meaning #4777
Comments
this looks like a missing feature with the markdown/html library we use, have raised an issue noties/Markwon#381 |
This is standard Markdown feature (automatically numbering ordered list). |
Biggest issue is that Element Desktop and Element Android handle this differently, so the answer will look different with different clients. Element Desktop also makes it into a list, but it does not do automatical numbering. List decorations are also dropped in the Direct Messages overview, there the answer would be just rendered as |
it is really horrible when you try to make an appointment and e.g. suggest "4. April" and depending whether the other person(s) use(s) element web, android, or iOS, they see "1. April". Then suddenly on 1. April you get a call why you're late. |
Have triaged on the WTFs board, will remove myself now 👍 |
How is this only a minor issue? This makes element unusable on Android. |
Because if sponsor reports issue, then it's a serious issue despite if it doesn't even affects the UX (or very minimally - see confetti animation or typing indicator redesign). |
to help clear up the labelling, this issue was originally marked as minor because "a suitable workaround exists", which in our case is disabling the markdown preference and the markdown setting is not enabled by default. however... it seems this is not actually the case and even without the markdown toggle disabled the list syntax is being unexpectedly processed, will upgrade the severity |
Fixed in v1.4.28 |
I think that fix would still change the meaning of messages in some scenarios, especially if the behaviour is not unified between platforms. For example:
Would turn the last message into:
|
The conversion fix is still not ideal for a normal user who just wants to send plain text messages. But at least it consistent between the platforms now, so errors should be easier to spot. |
Steps to reproduce
2. sounds good
2.
to1.
due to its internal conversion to numbered list (with a single item)This is incredibly awful.
Outcome
What did you expect?
That my message is displayed how it was sent.
What happened instead?
The meaning of my message was changed.
Operating system version
Android 10
Application version and app store
1.3.9
Homeserver
matrix.org
The text was updated successfully, but these errors were encountered: