Fixing numbered lists always starting from 1 #6473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OHGODTHANKYOU |
ouchadam
requested review from
a team and
fedrunov
and removed request for
a team
|
have also created a fix upstream noties/Markwon#409 |
ouchadam
commented
Jul 6, 2022
| final SpanFactory spanFactory = configuration.spansFactory().get(ListItem.class); | ||
|
|
||
| // Modified line | ||
| int number = Integer.parseInt(block.attributes().containsKey(START_KEY) ? block.attributes().get(START_KEY) : "1"); |
There was a problem hiding this comment.
this line is the fix for taking into account the starting position
… into account the initial starting position
- the test helper is a little hacky in order to covert the spans to something human readable
ouchadam
force-pushed
the
feature/adm/list-initial-value
branch
from
1effc1a to
ead8cec
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Includes the html tag start position when parsing html Lists.
Motivation and context
To fix the confusing behaviour of numbered lists losing their initial value #4777
Screenshots / GIFs
Tests
#.eg5. JulyTested devices