use clipboard hack to get deferred deeplink #7842
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElementBot
reviewed
Dec 23, 2022
| interface DeferredPermalinkService { | ||
|
|
||
| /** | ||
| * Checks system clipboard for matrix.to links and returns first room link if any found |
There was a problem hiding this comment.
⚠️ The first sentence of this KDoc does not end with the correct punctuation.
|
|
||
| package org.matrix.android.sdk.internal.session.permalinks | ||
|
|
||
| import android.content.ClipboardManager |
There was a problem hiding this comment.
- 🚫 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
|
SonarCloud Quality Gate failed. |
bmarty
reviewed
Feb 2, 2023
| /** | ||
| * Returns the deferredPermalinkService service associated with the session. | ||
| */ | ||
| fun deferredPermalinkService(): DeferredPermalinkService |
There was a problem hiding this comment.
I am not sure to understand why this code is on the SDK side. It should be at the application level.
| @@ -293,6 +293,7 @@ class HomeActivityViewModel @AssistedInject constructor( | |||
| .onEach { status -> | |||
| when (status) { | |||
| is SyncRequestState.Idle -> { | |||
| checkDeferredPermalink() | |||
There was a problem hiding this comment.
What is preventing this to be executed at each start (i.e. until the Clipboard is flushed?)
|
NIkita Fedrunov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
When a user follows a matrix.to link on mobile, it doesn't work because the app does not keep the link. Storing the link in the clipboard means it can be pasted to ensure the user reaches the room they intended to...
This is draft PR since it's blocked by
matrix-org/matrix.to#297
Motivation and context
closes #7673
Screenshots / GIFs
Tests
Tested devices
Checklist