Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous template special. errors with GCC 7+ #264

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

JM1
Copy link
Contributor

@JM1 JM1 commented Aug 9, 2018

Fix for #254. See discussion in #254 in #259.

@poulson
Copy link
Member

poulson commented Aug 9, 2018

LGTM. I will merge if/when the travis tests pass. Thanks!

@JM1
Copy link
Contributor Author

JM1 commented Aug 12, 2018

Travis tests fail because Clang 6.0 crashs, workaround for that will come later ( #263 ).

@poulson
Copy link
Member

poulson commented Aug 12, 2018

Which CL would you like me to review/merge first?

@JM1
Copy link
Contributor Author

JM1 commented Aug 13, 2018

CL?

This PR (#264) first, then I'll open a new PR for another .travis.yml patch, which will allow Clang 6.0 to fail (my assumption for allow_failures is that Clang crashs because of an internal compiler bug, which is not caused by invalid C++ code in Elemental).

@poulson poulson merged commit a666cf4 into elemental:master Aug 13, 2018
@poulson
Copy link
Member

poulson commented Aug 13, 2018

Sorry, I meant Pull Request, not Change List. I have internalized company lingo apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants