Ecto 3.12: Add Query.ByExpr structs next to the old Query.QueryExpr struct matching #198
+16
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #197
To get
mongodb_ecto
working withecto
3.12 I've done the naive thing and addedEcto.Query.ByExpr
structs next to the places whereEcto.Query.QueryExpr
was present.After the manually updating
ecto
to 3.12.5, the existing unit tests are working.However I would need guidance on how to properly set up the tests to work with both struct types, or how to not throw an error when using with an older ecto version that does not define this struct. Nor do I have any knowledge on how matrix testing works in elixir, so pointers on where the configuration would need to be updated would be appreciated as well :).