Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binding requests as keepalives #51

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Use binding requests as keepalives #51

merged 4 commits into from
Jul 23, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Jul 17, 2024

Close #49

Also, bumps deps as current credo failed with Elixir 1.17.

@LVala LVala self-assigned this Jul 17, 2024
@LVala LVala marked this pull request as ready for review July 18, 2024 07:24
@LVala LVala requested review from mickel8 and removed request for mickel8 July 18, 2024 07:25
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (2c89826) to head (680468a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   79.94%   80.45%   +0.51%     
==========================================
  Files          25       25              
  Lines        1436     1443       +7     
==========================================
+ Hits         1148     1161      +13     
+ Misses        288      282       -6     
Files Coverage Δ
lib/ex_ice/priv/candidate_pair.ex 63.63% <ø> (ø)
lib/ex_ice/priv/ice_agent.ex 84.41% <50.00%> (+0.82%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c89826...680468a. Read the comment docs.

@LVala LVala requested a review from mickel8 July 18, 2024 08:03
@mickel8 mickel8 merged commit cf3b814 into master Jul 23, 2024
2 checks passed
@mickel8 mickel8 deleted the binding-keepalives branch July 23, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use binding-requests as keepalives
2 participants