Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add pairs with srflx local candidate to the checklist #52

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Jul 23, 2024

Fixes #47

@mickel8 mickel8 requested a review from LVala July 23, 2024 16:19
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.11%. Comparing base (cf3b814) to head (c0d55fa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   80.62%   80.11%   -0.52%     
==========================================
  Files          25       25              
  Lines        1445     1428      -17     
==========================================
- Hits         1165     1144      -21     
- Misses        280      284       +4     
Files Coverage Δ
lib/ex_ice/priv/ice_agent.ex 83.90% <100.00%> (-0.55%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3b814...c0d55fa. Read the comment docs.

@mickel8 mickel8 merged commit 5c9212f into master Jul 24, 2024
4 checks passed
@mickel8 mickel8 deleted the srflx-cands branch July 24, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't add srflx candidates to the checklist
2 participants