Fix sending and handling keepalives #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 82.71% 81.45% -1.26%
==========================================
Files 25 25
Lines 1527 1548 +21
==========================================
- Hits 1263 1261 -2
- Misses 264 287 +23
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
sgfn
approved these changes
Sep 23, 2024
lib/ex_ice/priv/ice_agent.ex
Outdated
Comment on lines
1660
to
1666
| Logger.warning(""" | ||
| Ignoring keepalive success response, non-symmetric src and dst addresses. | ||
| Sent from: #{inspect({ka_local_cand.base.base_address, ka_local_cand.base.base_port})}, \ | ||
| to: #{inspect({ka_remote_cand.address, ka_remote_cand.port})} | ||
| Recv from: #{inspect({src_ip, src_port})}, on: #{inspect({local_cand.base.base_address, local_cand.base.base_port})} \ | ||
| Not refreshing last_seen time. \ | ||
| """) |
There was a problem hiding this comment.
Why is this a warning log? Is it more important than e.g. the one from the error response?
There was a problem hiding this comment.
I will change it to debug one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pair_infofunction that makes it easier to log information about pair. I will replace old logs incrementally.:keepalive->:keepalive_timeoutandhandle_keepalive->handle_keepalive_timeout