Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on gathering transactions #63

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Nov 27, 2024

No description provided.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.21%. Comparing base (5e88c90) to head (0cdcb22).

Files with missing lines Patch % Lines
lib/ex_ice/priv/ice_agent.ex 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   82.36%   83.21%   +0.85%     
==========================================
  Files          25       25              
  Lines        1548     1549       +1     
==========================================
+ Hits         1275     1289      +14     
+ Misses        273      260      -13     
Files with missing lines Coverage Δ
lib/ex_ice/priv/ice_agent.ex 86.52% <0.00%> (+1.26%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e88c90...0cdcb22. Read the comment docs.

@mickel8 mickel8 force-pushed the fix/crash-on-gathering-transactions branch from 41ea2e7 to 0cdcb22 Compare November 27, 2024 11:43
@mickel8 mickel8 force-pushed the fix/crash-on-gathering-transactions branch from 0cdcb22 to 9889322 Compare November 27, 2024 11:47
@mickel8 mickel8 merged commit d4d1a63 into master Nov 27, 2024
2 checks passed
@mickel8 mickel8 deleted the fix/crash-on-gathering-transactions branch November 27, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants