[Fixes] Small Fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linux fails because "userdesktop" can't be mounted: You'll need to have an exception for that like there was before your changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the logic for
love.filesystem.loadbecause I forgot to fix that in the last pr for fixingtest:isLuaAtLeastVersion. I have also changed howlove.filesystem.mountCommonPathworks by giving it a table of common path, mountpoint, and mode which validates if the common path exists (not empty) before trying to mount it accordingly.This is useful because even LÖVE for Android has empty paths, so we should be checking that.