Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update frame start detection #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update frame start detection #58

wants to merge 1 commit into from

Conversation

bgarderhagen
Copy link

Updated the functionality that detects frame start. Included both address bytes in STATE_WAIT_START. The first address byte is now fixed to 0x00.

@bgarderhagen
Update frame start detection
bc43657 
Updated the functionality that detects frame start. Included both address bytes in STATE_WAIT_START. The first address byte is now fixed to 0x00.
elupus
elupus requested changes Apr 5, 2024
View reviewed changes
Copy link
Owner

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its only zero sometimes. That byte is actually part of the full address. So we should likely extend the shouldacknack to tale the full 16 bit address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elupus elupus elupus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgarderhagen @elupus