Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow file urls #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sys-cf-ghrn
Copy link

@sys-cf-ghrn sys-cf-ghrn commented Jul 6, 2018

Allows access to local files via file://

@emarock
Copy link
Owner

emarock commented Jul 7, 2018

Thanks for the PR, I understand the use case it is trying to address and believe it's doable. Unfortunately the patch as it stands cannot be practically merged, as most of the changes are editorial and would create inconsistencies with the coding style.
I'm sure we can figure out pretty easily the minimum set of changes for supporting 'file://' URIs. Can you open an issue with a short description to track progress?

@sys-cf-ghrn
Copy link
Author

Sorry, I applied my code formatter to your files because they were unreadable in my editor. There appears to be a mixture of tabs and spaces in your project. I've reverted them, but I'd consider using something like prettier across your project. You can configure it to match your code style.

Here's what it looks like in my editor.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants